Deployment type for Download-Only fixed on DDI-API #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2019 13:17
Signed-off-by: Jeroen Laverman <[email protected]>
Signed-off-by: Jeroen Laverman <[email protected]>
|
@hawkbit-bot please verify |
a-sayyed
reviewed
Jun 5, 2019
...kbit-ddi-resource/src/main/java/org/eclipse/hawkbit/ddi/rest/resource/DdiRootController.java
Outdated
Show resolved
Hide resolved
a-sayyed
reviewed
Jun 5, 2019
...sitory/hawkbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/model/Action.java
Show resolved
Hide resolved
a-sayyed
reviewed
Jun 6, 2019
...-ddi-resource/src/test/java/org/eclipse/hawkbit/ddi/rest/resource/DdiDeploymentBaseTest.java
Outdated
Show resolved
Hide resolved
a-sayyed
reviewed
Jun 6, 2019
...-ddi-resource/src/test/java/org/eclipse/hawkbit/ddi/rest/resource/DdiDeploymentBaseTest.java
Outdated
Show resolved
Hide resolved
a-sayyed
reviewed
Jun 6, 2019
...-ddi-resource/src/test/java/org/eclipse/hawkbit/ddi/rest/resource/DdiDeploymentBaseTest.java
Show resolved
Hide resolved
Signed-off-by: Jeroen Laverman <[email protected]>
laverman
commented
Jun 7, 2019
...-ddi-resource/src/test/java/org/eclipse/hawkbit/ddi/rest/resource/DdiDeploymentBaseTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jeroen Laverman <[email protected]>
|
looks good 👍 |
schabdo
changed the title
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
…#848) Signed-off-by: Jeroen Laverman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For action type Download Only it doesn't make sense to send
deployment.download = attempt, deployment.update = attemptsince the device shall only download the artefact not install it.Therefore, the response should look like the following:
deployment.download = forced, deployment.update = skipSince this feature is quite new, I hope breaking the API here is acceptable? However, I feel the current behaviour is not what one would expect.
Feedback welcome!
PS: I fixed some typos along the way
Signed-off-by: Jeroen Laverman [email protected]