Removed external artifact from repository. #322
Conversation
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
| @@ -122,7 +121,7 @@ public Message onAuthenticationRequest(final Message message) { | |||
| * download this artifact | |||
| */ | |||
| private void checkIfArtifactIsAssignedToTarget(final TenantSecurityToken secruityToken, | |||
| final LocalArtifact localArtifact) { | |||
| final org.eclipse.hawkbit.repository.model.Artifact localArtifact) { | |||
There was a problem hiding this comment.
Rename the parameter localArtifact as well
| @@ -146,7 +146,8 @@ private void checkByTargetId(final LocalArtifact localArtifact, final Long targe | |||
| LOG.info("download security check for target {} and artifact {} granted", targetId, localArtifact); | |||
| } | |||
|
|
|||
| private void checkByControllerId(final LocalArtifact localArtifact, final String controllerId) { | |||
| private void checkByControllerId(final org.eclipse.hawkbit.repository.model.Artifact localArtifact, | |||
There was a problem hiding this comment.
I'm not sure whether renaming LocalArtifact to Artifact is a good idea or not: As you can see in the following changes you'll get a lot of name clashes. Can't you find a better name for one of the involved classes?
There was a problem hiding this comment.
Artifact was actually always the name. LocalArtifact was a sub-interface. besides the mistake was made on DMF side. It uses repository naming schema, i.e. it should be called DmfArtifact as in the other APIs.
| final MgmtArtifact artifactRest = new MgmtArtifact(); | ||
| artifactRest.setType(type); |
There was a problem hiding this comment.
Just to be sure: This will change the API, is it intended?
There was a problem hiding this comment.
Well, it was an unused part of the API. So I think its save to remove it. We supported only one type (local) anyway.
| @@ -53,10 +53,19 @@ | |||
| @JoinColumn(name = "software_module", nullable = false, updatable = false, foreignKey = @ForeignKey(value = ConstraintMode.CONSTRAINT, name = "fk_assigned_sm")) | |||
| private JpaSoftwareModule softwareModule; | |||
|
|
|||
| @Column(name = "sha1_hash", length = 40, nullable = true) | |||
There was a problem hiding this comment.
What about javax.validation annotations?
There was a problem hiding this comment.
We never do them execept if we want to do a validation that is not supported by the database
Signed-off-by: kaizimmerm <[email protected]>
First task for #197
Signed-off-by: kaizimmerm [email protected]