Fix lastModifiedBy on modification perfomed by the JpaRolloutExecutor #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
avgustinmm
force-pushed
the
fix/last_modified_by
branch
from
a13eb41 to
ff2673f
Compare
avgustinmm
changed the title
avgustinmm
force-pushed
the
fix/last_modified_by
branch
from
ff2673f to
6f25522
Compare
avgustinmm
force-pushed
the
fix/last_modified_by
branch
3 times, most recently
from
20986cb to
be942ff
Compare
1. The auditor is got on transaction commit - so haven't used the tenant & user context until now - write system 2. The start/stop/delete are called by the user (saved in lastModifiedBy) but then executed in JpaRolloutExecutor So the change is: 1. Fix auditor for actions taken by JpaRolloutExecutor to be the createdBy 2. for start/stop/delete the auditor is set to the lastModifiedBy for the transaction (hence all action taken) Signed-off-by: Marinov Avgustin <[email protected]>
avgustinmm
force-pushed
the
fix/last_modified_by
branch
from
be942ff to
9b9a262
Compare
strailov
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lastModifiedBy on modification perfomed by the JpaRolloutExecutor
So the change is: