Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spring config of RSQLUtilityTest #1351

Merged

Conversation

stefbehl
Copy link
Contributor

@stefbehl stefbehl commented Apr 20, 2023

In some test environments (e.g. the Eclipse CI infrastructure), the test case RSQLUtilityTest#correctRsqlWithOverdueMacro fails with a NullPointerException. Strangely enough the test used to pass in the scope of our CircleCI builds.

This PR delivers a fix which makes the test reliable wrt its Spring configuration (auto-wiring of beans etc.).

Copy link
Contributor

@StefanKlt StefanKlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @stefbehl

@stefbehl stefbehl merged commit 328ded7 into eclipse-hawkbit:master Apr 20, 2023
@stefbehl stefbehl deleted the fix/flaky-rsql-utility-test branch April 20, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants