Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for deployment groups and rollouts #1341

Conversation

strailov
Copy link
Contributor

@strailov strailov commented Apr 4, 2023

No description provided.

@hawkbit-bot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@stefbehl stefbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @strailov! Please see my review finding.

Signed-off-by: Stanislav Trailov <[email protected]>
@stefbehl stefbehl linked an issue Apr 6, 2023 that may be closed by this pull request
Copy link
Contributor

@stefbehl stefbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @strailov!

@stefbehl stefbehl merged commit 771ef8e into eclipse-hawkbit:master Apr 13, 2023
@stefbehl stefbehl deleted the feature/deploygroups-rollout-validation branch April 13, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploygroups do not validate their relation with the rollout
3 participants