Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Spring Boot 2.7.10 #1320

Merged

Conversation

stefbehl
Copy link
Contributor

@stefbehl stefbehl commented Feb 8, 2023

This pull request migrates Eclipse hawkBit from Spring Boot 2.3 to Spring Boot 2.7.8. The migration to Spring Boot 3.* can be done in a separate step.

Update: We decided to upgrade to Spring Boot 2.7.10 to also resolve the latest CVEs found.

Signed-off-by: Stefan Behl [email protected]

@stefbehl stefbehl added this to the 0.3.0M8 milestone Feb 8, 2023
Copy link
Contributor

@MartB MartB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for consolidating and taking over the spring boot migration!
I have some really minor extra nitpicks but no blockers lgtm 👍

@MartB
Copy link
Contributor

MartB commented Feb 23, 2023

Very nice progress, I am going to take it for a spin and test it.

I had a random test failure on my very first run though:

https://github.com/eclipse/hawkbit/blob/21f1569881614eaa07e5f0d74850a5157fc35864/hawkbit-repository/hawkbit-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java#L1105

[ERROR]   ControllerManagementTest.findMessagesByActionStatusId:1105 [Message of action-status] 
expected: "proceeding message 2"
 but was: "proceeding message 1"

I think this is unrelated, as the second build worked, but I want to note it anyway.

@MartB
Copy link
Contributor

MartB commented Feb 26, 2023

Something is wrong and i dont know what it is.

Im pretty sure it should not return data like this:

HTTP/1.1 200 OK
Date: Sun, 26 Feb 2023 00:35:04 GMT
Content-Type: application/json;charset=utf-8
ETag: "0d4500e3db48c4b14cb4b1c3379083dd6"
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
Cache-Control: no-cache, no-store, max-age=0, must-revalidate
Pragma: no-cache
Expires: 0
X-Frame-Options: DENY
Content-Length: 218

{
   "config":{
      "polling":{
         "sleep":"00:00:30"
      }
   },
   "_links":{
      "deploymentBase":{
         "href":"http://...:8080/DEFAULT/controller/v1/Censored/deploymentBase/37?c=444846635{&actionHistory}",
         "templated":true
      }
   }
}

the {} around actionHistory are invalid here and lead to this

2023-02-26 01:40:06.031  WARN 1339496 --- [tp2081964843-58] .w.s.m.s.DefaultHandlerExceptionResolver : Resolved [org.springframework.web.method.annotation.MethodArgumentTypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'int'; nested exception is java.lang.NumberFormatException: For input string: "444846635{"]

This is probably wrong for more of these.

@stefbehl
Copy link
Contributor Author

@MartB @floruschbaschan @strailov @zyga Thanks for your input and reviews! We would like to merge this PR soon as it is a prereq for the milestone release. If you want to take a final look at the changes, please do that until end of this week.
Thanks and regards, Stefan

@stefbehl stefbehl removed this from the 0.3.0M8 milestone Mar 21, 2023
@stefbehl stefbehl added this to the 0.3.0M8 milestone Mar 22, 2023
@stefbehl
Copy link
Contributor Author

We were just about to merge this PR but because of the newly detected CVEs we need to evaluate if we can directly migrate to Boot 2.7.10 (which was just released).

@stefbehl stefbehl changed the title Migration to Spring Boot 2.7.8 Migration to Spring Boot 2.7.10 Mar 23, 2023
@stefbehl
Copy link
Contributor Author

stefbehl commented Mar 23, 2023

Looks good so far. I also executed the tests against a MySql 8 and all tests were passing.

@stefbehl stefbehl merged commit 4a3a79a into eclipse-hawkbit:master Mar 28, 2023
@stefbehl stefbehl deleted the feature/spring-boot-27-migration branch March 28, 2023 05:16
@stefbehl stefbehl restored the feature/spring-boot-27-migration branch March 28, 2023 05:21
@stefbehl stefbehl deleted the feature/spring-boot-27-migration branch April 3, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants