-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Spring Boot 2.7.10 #1320
Migration to Spring Boot 2.7.10 #1320
Conversation
...awkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/ActionRepository.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for consolidating and taking over the spring boot migration!
I have some really minor extra nitpicks but no blockers lgtm 👍
...jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/RepositoryApplicationConfiguration.java
Outdated
Show resolved
Hide resolved
...rest/hawkbit-mgmt-api/src/main/java/org/eclipse/hawkbit/mgmt/rest/api/MgmtActionRestApi.java
Show resolved
Hide resolved
Very nice progress, I am going to take it for a spin and test it. I had a random test failure on my very first run though: [ERROR] ControllerManagementTest.findMessagesByActionStatusId:1105 [Message of action-status]
expected: "proceeding message 2"
but was: "proceeding message 1" I think this is unrelated, as the second build worked, but I want to note it anyway. |
Something is wrong and i dont know what it is. Im pretty sure it should not return data like this:
the {} around actionHistory are invalid here and lead to this
This is probably wrong for more of these. |
...t-ddi-resource/src/main/java/org/eclipse/hawkbit/ddi/rest/resource/DataConversionHelper.java
Outdated
Show resolved
Hide resolved
hawkbit-repository/hawkbit-repository-jpa/src/main/resources/hawkbit-jpa-defaults.properties
Show resolved
Hide resolved
...e/src/main/java/org/eclipse/hawkbit/autoconfigure/security/SecurityManagedConfiguration.java
Show resolved
Hide resolved
@MartB @floruschbaschan @strailov @zyga Thanks for your input and reviews! We would like to merge this PR soon as it is a prereq for the milestone release. If you want to take a final look at the changes, please do that until end of this week. |
We were just about to merge this PR but because of the newly detected CVEs we need to evaluate if we can directly migrate to Boot 2.7.10 (which was just released). |
Looks good so far. I also executed the tests against a MySql 8 and all tests were passing. |
This pull request migrates Eclipse hawkBit from Spring Boot 2.3 to Spring Boot 2.7.8. The migration to Spring Boot 3.* can be done in a separate step.
Update: We decided to upgrade to Spring Boot 2.7.10 to also resolve the latest CVEs found.
Signed-off-by: Stefan Behl [email protected]