added triggeredBy for rollouts and autoassignment #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Sayed <[email protected]>
a-sayyed
commented
Sep 24, 2020
...it-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaRolloutManagement.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
schabdo
reviewed
Sep 25, 2020
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
schabdo
reviewed
Sep 25, 2020
...hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/JpaAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Sayed <[email protected]>
schabdo
reviewed
Sep 25, 2020
...ository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/JpaTargetFilterQuery.java
Outdated
Show resolved
Hide resolved
|
What about tests if the field is filled correctly by different use cases? |
schabdo
reviewed
Sep 25, 2020
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Sayed <[email protected]>
…ction_triggered_by
a-sayyed
commented
Sep 25, 2020
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
...ory-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaTargetFilterQueryManagement.java
Outdated
Show resolved
Hide resolved
...itory-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/autoassign/AutoAssignChecker.java
Outdated
Show resolved
Hide resolved
...hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/JpaAction.java
Outdated
Show resolved
Hide resolved
...ository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/JpaTargetFilterQuery.java
Outdated
Show resolved
Hide resolved
...rc/main/resources/db/migration/SQL_SERVER/V1_12_16__add_action_initiated_by___SQL_SERVER.sql
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Sayed <[email protected]>
krishna-devolo
pushed a commit
to devolo/hawkbit
that referenced
this pull request
Sep 23, 2021
* added triggeredBy for rollouts and autoassignment Signed-off-by: Ahmed Sayed <[email protected]> * use createdBy as fallback for triggeredBy in AutoAssignChecker Signed-off-by: Ahmed Sayed <[email protected]> * removed 'NOT NULL' from db migration scripts for JpaTargetFilterQuery Signed-off-by: Ahmed Sayed <[email protected]> * fixed tests Signed-off-by: Ahmed Sayed <[email protected]> * fixed review findings Signed-off-by: Ahmed Sayed <[email protected]> * inlined redundant method in JpaDeploymentManagement Signed-off-by: Ahmed Sayed <[email protected]> * added tests + renamed property to 'initiatedBy' Signed-off-by: Ahmed Sayed <[email protected]> * fixed review findings Signed-off-by: Ahmed Sayed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve traceability of created actions, it should be possible to track who triggered an action (directly or indirectly).
This PR adds a new field to the Action entity that corresponds to the user who initiated/triggered an assignment, via manual/auto assignment or via a Rollout.