Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract esmf-native-support module from samm-cli #662

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Oct 18, 2024


Description

Introduces a new module, esmf-native-support, that can be used as a dependency
in projects that use esmf-sdk and use GraalVM native-image compilation.

Fixes #661.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit 6a5fa29 into eclipse-esmf:main Nov 4, 2024
4 checks passed
@atextor atextor deleted the 661-refactor-native-image-configuration-into-separate-module branch November 4, 2024 11:56
Copy link

github-actions bot commented Nov 6, 2024

Release v2.9.7 addresses this.

1 similar comment
Copy link

github-actions bot commented Nov 7, 2024

Release v2.9.7 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Refactor native-image configuration to make it reusable
2 participants