-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract esmf-native-support module from samm-cli #662
Merged
atextor
merged 18 commits into
eclipse-esmf:main
from
bci-oss:661-refactor-native-image-configuration-into-separate-module
Nov 4, 2024
Merged
Extract esmf-native-support module from samm-cli #662
atextor
merged 18 commits into
eclipse-esmf:main
from
bci-oss:661-refactor-native-image-configuration-into-separate-module
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yauhenikapl
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
core/esmf-native-support/src/main/java/org/eclipse/esmf/nativefeatures/Native.java
Show resolved
Hide resolved
atextor
deleted the
661-refactor-native-image-configuration-into-separate-module
branch
November 4, 2024 11:56
Release v2.9.7 addresses this. |
1 similar comment
Release v2.9.7 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new module,
esmf-native-support
, that can be used as a dependencyin projects that use esmf-sdk and use GraalVM native-image compilation.
Fixes #661.
Type of change
Please delete options that are not relevant.
Checklist: