Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable code style check #604

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Jul 9, 2024


Description

Re-enables the code style check that was disabled in #602 due to technical reasons.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [-] I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [-] I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit fe844a1 into eclipse-esmf:main Jul 9, 2024
1 check passed
@atextor atextor deleted the reenable-style-check branch July 9, 2024 06:33
Copy link

Release v2.9.0 addresses this.

@eclipse-esmf eclipse-esmf deleted a comment from github-actions bot Jul 11, 2024
@eclipse-esmf eclipse-esmf deleted a comment from github-actions bot Jul 11, 2024
@eclipse-esmf eclipse-esmf deleted a comment from github-actions bot Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants