Introduction of consumer vs. build time POMs #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schabdo
force-pushed
the
137-introduce-consumer-pom
branch
from
43f9a56
to
d916aa5
Compare
|
@schabdo Does it make sense to document the intent and location of the flattened pom? Or is this something self-explanatory for everyone who might be interested? |
|
If you agree I'd add a comment right above the plugin execution to shed some light on the intention and what's going on there. For consumer side I wouldn't mention/document anything since it's completely transparent |
|
@schabdo This sounds sensible, please go ahead :) |
schabdo
force-pushed
the
137-introduce-consumer-pom
branch
from
99fb5bd
to
da76a3b
Compare
|
done |
atextor
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #137
Not sure whether or not it make sense to flatten the POM of the CLI, too. I'm up for discussion and happily awaiting your feedback on that. So I leave it up to the reviewer ...