Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@user.home can be used in -eclipse.keyring argument but not with -eclipse.password. #652

Closed
mPorhel opened this issue Jul 2, 2024 · 1 comment

Comments

@mPorhel
Copy link
Contributor

mPorhel commented Jul 2, 2024

-eclipse.keyring and -eclipse.password runtime options can be used to change the location of the secure storage and bypass the password provider mecanism.

They are handled in org.eclipse.equinox.internal.security.storage.SecurePreferencesMapper::open.
@user.home is replaced with the corresponding value.path during retrieval of the secure storage / keyring file in content in SecurePreferencesMapper::getKeyringFile but not in password file retrieval in SecurePreferencesMapper::processPassword

The documentation of those options clearly indicates that protection of the password file must be considered. Having the possibility to use @user.homecan help to avoid absolute path or computation from user name on the command line if user profile folder is used to store this file (or as indirect mounting point).

@https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.user%2Freference%2Fref-securestorage-options.htm

Password file
The password provider mechanism can be bypassed if you specify the "-eclipse.password " runtime option. In this case the contents of the file you specified as the argument will be used as a master password. While this option is valuable in some circumstances (such as headless applications), the protection of the password file becomes a consideration. The password file can be protected by the operating system access rights and/or by placing it on a removable storage, such as a USB key.

mPorhel added a commit to mPorhel/equinox that referenced this issue Jul 2, 2024
mPorhel added a commit to mPorhel/equinox that referenced this issue Jul 2, 2024
mPorhel added a commit to mPorhel/equinox that referenced this issue Jul 2, 2024
@HannesWell
Copy link
Member

Fixed with #653

Thank you @mPorhel for providing a fix. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants