Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #102. Do not prevent user from relying on gdbserver in PATH… #103

Merged
merged 1 commit into from
Mar 19, 2016

Conversation

sukidog
Copy link
Contributor

@sukidog sukidog commented Mar 18, 2016

… and specifying exe as simple name

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…gdbserver in PATH and specifying exe as simple name
@ilg-ul
Copy link
Contributor

ilg-ul commented Mar 19, 2016

ah, so this is the problem...

@flit, could you change the logic behind the executable field, to match the logic existing in the openocd & j-link plug-ins? I guess there are no such validations there.

if you know of other places where you introduced behaviour changes, we should discuss if the other plug-ins need adjustments, but the behaviour should be consistent between all debugging plug-ins.

@sukidog
Copy link
Contributor Author

sukidog commented Mar 19, 2016

I can't tell if you're asking me to change the behavior in the pyocd plugin to be like the others or the other way around

John

On Mar 19, 2016, at 12:34 PM, Liviu Ionescu notifications@github.com wrote:

ah, so this is the problem...

@flit, could you change the logic behind the executable field, to match the logic existing in the openocd & j-link plug-ins? I guess there are no such validations there.

if you know of other places where you introduced behaviour changes, we should discuss if the other plug-ins need adjustments, but the behaviour should be consistent between all debugging plug-ins.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@ilg-ul
Copy link
Contributor

ilg-ul commented Mar 19, 2016

no, I'm asking Chris Reed @flit, he's the author of the pyocd plug-in, and I think he is in the best position to find a solution.

@flit
Copy link
Contributor

flit commented Mar 19, 2016

Can you describe the current behaviour? It looked pretty simple to me. I didn't add or remove any logic related to that field when I originally created the plugin.

@sukidog improved the plugin by reporting to the user if the executable could not be found. This is important, because the plugin UI runs the pyOCD executable in order to populate the board and target fields.

Btw, for all intents and purposes, @sukidog is co-owner of the plugin. He can make decisions about the plugin.

@sukidog
Copy link
Contributor Author

sukidog commented Mar 19, 2016

We've had this discussion before. Chris and I co-own this plugin and I will probably be the primary maintainer of it.

John

On Mar 19, 2016, at 12:58 PM, Liviu Ionescu notifications@github.com wrote:

no, I'm asking Chris Reed @flit, he's the author of the pyocd plug-in, and I think he is in the best position to find a solution.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@flit
Copy link
Contributor

flit commented Mar 19, 2016

But in general, yes I completely agree that behaviour should be the same for all the debugging plugins.

@ilg-ul
Copy link
Contributor

ilg-ul commented Mar 19, 2016

@sukidog improved the plugin

sorry, the copyright notice refers to "Chris Reed" and "John Cortell"; you're obviously free to use any alias you like, but since there is no reference to your real names, you should assume some misunderstandings.


otherwise, regarding the plug-in behaviour, if I got it right, the point is not to simply validate the field (which the other plug-ins do not), but to call the program to get some additional data to populate the other fields. and the suggested patch fixes this problem. can you confirm this?

@sukidog
Copy link
Contributor Author

sukidog commented Mar 19, 2016

The plugin has been calling pyocd's gdbserver all along to get the list of
plugged-in boards. The only thing this pull request does is make it
possible for that logic to work when the user has pyOCD in PATH and he
has specified the gdbserver by simple name (sans path). BTW, this is not a
hypothetical scenario. This deficiency was found and reported to me by a
user.

On Sat, Mar 19, 2016 at 1:25 PM, Liviu Ionescu notifications@github.com
wrote:

@sukidog https://github.com/sukidog improved the plugin

sorry, the copyright notice refers to "Chris Reed" and "John Cortell";
you're obviously free to use any alias you like, but since there is no

reference to your real names, you should assume some misunderstandings.

otherwise, regarding the plug-in behaviour, if I got it right, the point
is not to simply validate the field (which the other plug-ins do not), but
to call the program to get some additional data to populate the other
fields. and the suggested patch fixes this problem. can you confirm this?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#103 (comment)

ilg-ul added a commit that referenced this pull request Mar 19, 2016
Fix issue #102. Do not prevent user from relying on gdbserver in PATH…
@ilg-ul ilg-ul merged commit f9cb996 into eclipse-embed-cdt:develop Mar 19, 2016
@ilg-ul
Copy link
Contributor

ilg-ul commented Mar 19, 2016

please check 2.12.1-201603192008 from updates-test.

@sukidog sukidog deleted the issue102_pyocd branch March 21, 2016 18:25
@ilg-ul
Copy link
Contributor

ilg-ul commented Apr 19, 2016

fixed in 2.12.1-201604190915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants