-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #102. Do not prevent user from relying on gdbserver in PATH… #103
Conversation
…gdbserver in PATH and specifying exe as simple name
ah, so this is the problem... @flit, could you change the logic behind the executable field, to match the logic existing in the openocd & j-link plug-ins? I guess there are no such validations there. if you know of other places where you introduced behaviour changes, we should discuss if the other plug-ins need adjustments, but the behaviour should be consistent between all debugging plug-ins. |
I can't tell if you're asking me to change the behavior in the pyocd plugin to be like the others or the other way around John
|
no, I'm asking Chris Reed @flit, he's the author of the pyocd plug-in, and I think he is in the best position to find a solution. |
Can you describe the current behaviour? It looked pretty simple to me. I didn't add or remove any logic related to that field when I originally created the plugin. @sukidog improved the plugin by reporting to the user if the executable could not be found. This is important, because the plugin UI runs the pyOCD executable in order to populate the board and target fields. Btw, for all intents and purposes, @sukidog is co-owner of the plugin. He can make decisions about the plugin. |
We've had this discussion before. Chris and I co-own this plugin and I will probably be the primary maintainer of it. John
|
But in general, yes I completely agree that behaviour should be the same for all the debugging plugins. |
sorry, the copyright notice refers to "Chris Reed" and "John Cortell"; you're obviously free to use any alias you like, but since there is no reference to your real names, you should assume some misunderstandings. otherwise, regarding the plug-in behaviour, if I got it right, the point is not to simply validate the field (which the other plug-ins do not), but to call the program to get some additional data to populate the other fields. and the suggested patch fixes this problem. can you confirm this? |
The plugin has been calling pyocd's gdbserver all along to get the list of On Sat, Mar 19, 2016 at 1:25 PM, Liviu Ionescu notifications@github.com
|
Fix issue #102. Do not prevent user from relying on gdbserver in PATH…
please check 2.12.1-201603192008 from updates-test. |
fixed in 2.12.1-201604190915 |
… and specifying exe as simple name