Initial support for Pages 4.0 M1 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjan Tijms <[email protected]>
arjantijms
requested review from
joakime,
AndyGee,
markt-asf,
volosied,
edbratt and
pnicolucci
pnicolucci
reviewed
Dec 8, 2023
There was a problem hiding this comment.
We need to bump the Java version to a min of 17 as well eventually: https://github.com/jakartaee/pages/blob/master/spec/src/main/asciidoc/ServerPages.adoc#c1-changes-between-jsp-40-and-jsp-31 due to jakartaee/expression-language#201
We can do that in a follow on PR if necessary but wanted to note it here.
Also removed source 11 from javadoc, and the older options for doclint no. Signed-off-by: Arjan Tijms <[email protected]>
You are right. I updated the PR. Might be best to do it here right away. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Jakarta Pages API to 4.0-M1 and makes sure the code compiles again