Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandoning JDK8 support + 3.3.0-SNAPSHOT #45

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Aug 21, 2024

No description provided.

Copy link
Contributor

@pzygielo pzygielo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase and squash to single commit, please?

@dmatej
Copy link
Contributor Author

dmatej commented Feb 3, 2025

Could you rebase and squash to single commit, please?

It was already rebased, but ok, I can squash those 4 commits, I don't think we would revert them.

* Added impl package to exports - CountStatisticImpl is used by GF
* Base and upper JDK versions set both to 11
* No need to exclude module-info with current compiler
* Project version increased to 3.3.0-SNAPSHOT
  * Note that for 4.0.0 we would have to rebuild all intermediate dependencies
    of GlassFish, ie. webservices-osgi, OR patch their manifests (nasty hack).
  * Nothing much changes in implementation, we just abandon Java 8.

Signed-off-by: David Matějček <[email protected]>
@pzygielo pzygielo merged commit 9db1d7f into eclipse-ee4j:master Feb 3, 2025
2 checks passed
@dmatej dmatej deleted the jdk23 branch February 3, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants