Skip to content

JAX-RS 2.1.3 (Jakarta Maven Coordinates and OSGi fixes) [master]#3991

Closed
mkarg wants to merge 6 commits intoeclipse-ee4j:masterfrom
mkarg:jaxrs-2.1.3
Closed

JAX-RS 2.1.3 (Jakarta Maven Coordinates and OSGi fixes) [master]#3991
mkarg wants to merge 6 commits intoeclipse-ee4j:masterfrom
mkarg:jaxrs-2.1.3

Conversation

@mkarg
Copy link
Member

@mkarg mkarg commented Nov 17, 2018

Using JAX-RS 2.1.3 (i. e. Jakarta Maven Coordinates and OSGi fixes) instead of JAX-RS 2.1 (i. e. javax Maven Coordinates).

See also #3994.

@mkarg mkarg changed the title JAX-RS 2.1.3 (Jakata Maven Coordinates and OSGi fixes) JAX-RS 2.1.3 (Jakarta Maven Coordinates and OSGi fixes) Nov 17, 2018
@mkarg
Copy link
Member Author

mkarg commented Nov 17, 2018

It is rather obvious that Travis fails, as that service has no access to JAX-RS's private staging area. To make it run, JAX-RS MUST be released to Maven Central. Same problem as JAX-RS itself has upstream with JAXB-RI.

@jansupol
Copy link
Contributor

If parent is changed to 1.0.5 and
if travis gets executed with -Pstaging,
then the Travis will run and validate the changes.
@mkarg Can you update the PR? Thank you

@mkarg
Copy link
Member Author

mkarg commented Nov 19, 2018

See 3e61e75 and 7486bc0, but Travis still fails. How should Travis be able to access the private OSSRH staging area of JAX-RS? Travis is not a JAX-RS committer, so he has no access rights.

@mkarg
Copy link
Member Author

mkarg commented Nov 20, 2018

@jansupol

Tests in error: JaxRsRiBundleTest.:51 » ClassNotFound javax.ws.rs.core.UriBuilder not ...

Any ideas?

@jansupol
Copy link
Contributor

I think I found it. jaxrs-ri bundle does not export javax.ws.rs. To do that:

@jansupol
Copy link
Contributor

@mkarg Please make this PR towards EE4J_8 branch

@mkarg
Copy link
Member Author

mkarg commented Nov 21, 2018

Please make this PR towards EE4J_8 branch

@jansupol You mean including the proposed changed and then rebase ontop of EE4J_8?

@jansupol
Copy link
Contributor

Yes please. We have many changes in EE4J_8 branch only, so we will merge the branch to master after 2.28 release. I plan to keep master buildable against maven central till then, so I'd actually close this PR. It's good it passes, though.

@mkarg
Copy link
Member Author

mkarg commented Nov 21, 2018

@jansupol Travis passes. :-) I will rebase the PR ontop EE4J_8 now. Stay tuned.

@mkarg mkarg changed the title JAX-RS 2.1.3 (Jakarta Maven Coordinates and OSGi fixes) JAX-RS 2.1.3 (Jakarta Maven Coordinates and OSGi fixes) [master] Nov 21, 2018
@mkarg
Copy link
Member Author

mkarg commented Nov 21, 2018

@jansupol See #3994.

@jansupol
Copy link
Contributor

Closing this in favor of #3994.

@jansupol jansupol closed this Nov 22, 2018
@mkarg mkarg deleted the jaxrs-2.1.3 branch November 22, 2018 11:02
@jansupol jansupol mentioned this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants