Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpServletMapping returned after AsyncContext.dispatch() has incorrect values #22079

Open
glassfishrobot opened this issue Jul 19, 2017 · 3 comments

Comments

@glassfishrobot
Copy link

HttpServletRequest.getHttpServletMapping() states:

If the currently active Servlet invocation was obtained by a call to AsyncContext.dispatch(), the returned HttpServletMapping is the one corresponding to the path that caused the first Servlet in the invocation sequence to be invoked.

The current implementation violates this proviso. It currently returns the mapping corresponding to the last Servlet in the invocation sequence.

@glassfishrobot
Copy link
Author

@arjantijms arjantijms reopened this Apr 7, 2022
@arjantijms
Copy link
Contributor

Turns out the initial values and behaviour were right after all, but the javadoc and therefor the TCK assertion was wrong. This was rectified in jakartaee/servlet#377 and therefor this issue needs to be reverted for GF 7.

@arjantijms arjantijms modified the milestones: 5.0, 7.0.0 Apr 7, 2022
@arjantijms arjantijms self-assigned this Apr 7, 2022
arjantijms added a commit to arjantijms/glassfish that referenced this issue Apr 8, 2022
@arjantijms arjantijms removed this from the 7.0.0 milestone Dec 14, 2022
Copy link

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

@github-actions github-actions bot added the Stale label Dec 15, 2023
@dmatej dmatej removed the Stale label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants