Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the getStringProperty method of the DataAddress #56

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Fixes compile errors that arose due to the getProperty -> getStringProperty transition in the DataAddress class.

Why it does that

compile errors

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Aug 18, 2023
@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Test Results

52 tests  ±0   52 ✔️ ±0   17s ⏱️ +4s
13 suites ±0     0 💤 ±0 
13 files   ±0     0 ±0 

Results for commit 48ac2d2. ± Comparison against base commit 62c3123.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Patch coverage: 90.00% and no project coverage change.

Comparison is base (62c3123) 72.86% compared to head (48ac2d2) 72.86%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   72.86%   72.86%           
=======================================
  Files          20       20           
  Lines         479      479           
  Branches       17       17           
=======================================
  Hits          349      349           
  Misses        129      129           
  Partials        1        1           
Files Changed Coverage Δ
...dc/connector/provision/aws/s3/S3StatusChecker.java 0.00% <0.00%> (ø)
.../provision/aws/s3/S3BucketProvisionedResource.java 100.00% <100.00%> (ø)
.../aws/s3/S3ConsumerResourceDefinitionGenerator.java 100.00% <100.00%> (ø)
.../connector/dataplane/aws/s3/S3DataSinkFactory.java 100.00% <100.00%> (ø)
...onnector/dataplane/aws/s3/S3DataSourceFactory.java 100.00% <100.00%> (ø)
...dation/S3DataAddressCredentialsValidationRule.java 100.00% <100.00%> (ø)
...aws/s3/validation/S3DataAddressValidationRule.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 19ca63b into main Aug 18, 2023
@ndr-brt ndr-brt deleted the fix/compile_errors_dataaddress branch August 18, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants