Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract validator-data-address-s3 module #354

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 21, 2024

What this PR changes/adds

Extracts validator-data-address-s3 module

Why it does that

modularity

Further notes

  • cleaned up end to end tests a little and ci workflows as well

Linked Issue(s)

Closes #352

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Jun 21, 2024
Copy link

github-actions bot commented Jun 21, 2024

Test Results

17 files  ±0  17 suites  ±0   26s ⏱️ +17s
62 tests  - 2  62 ✅  - 2  0 💤 ±0  0 ❌ ±0 
64 runs   - 2  64 ✅  - 2  0 💤 ±0  0 ❌ ±0 

Results for commit 5ebbd15. ± Comparison against base commit 484fb46.

This pull request removes 19 and adds 17 tests. Note that renamed tests count towards both.
org.eclipse.edc.aws.s3.S3DestinationDataAddressValidatorExtensionTest ‑ initialize(S3DataAddressValidatorExtension, ServiceExtensionContext)
org.eclipse.edc.aws.s3.validation.S3DestinationDataAddressValidatorTest ‑ should_fail_when_required_fields_are_missing()
org.eclipse.edc.aws.s3.validation.S3DestinationDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid()
org.eclipse.edc.aws.s3.validation.S3SourceDataAddressValidatorTest ‑ should_fail_when_both_object_name_and_prefix_are_missing()
org.eclipse.edc.aws.s3.validation.S3SourceDataAddressValidatorTest ‑ should_fail_when_region_or_bucketName_is_missing()
org.eclipse.edc.aws.s3.validation.S3SourceDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid_with_object_name()
org.eclipse.edc.aws.s3.validation.S3SourceDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid_with_object_prefix()
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkFactoryTest ‑ [1] validBucketName,  , validAccessKeyId, validSecretAccessKey
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkFactoryTest ‑ [2]  , validRegion, validAccessKeyId, validSecretAccessKey
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkFactoryTest ‑ validate_ShouldSucceedIfPropertiesAreValid()
…
org.eclipse.edc.aws.s3.validator.S3DataAddressValidatorExtensionTest ‑ initialize(S3DataAddressValidatorExtension, ServiceExtensionContext)
org.eclipse.edc.aws.s3.validator.S3DestinationDataAddressValidatorTest ‑ should_fail_when_required_fields_are_missing()
org.eclipse.edc.aws.s3.validator.S3DestinationDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid()
org.eclipse.edc.aws.s3.validator.S3SourceDataAddressValidatorTest ‑ should_fail_when_both_object_name_and_prefix_are_missing()
org.eclipse.edc.aws.s3.validator.S3SourceDataAddressValidatorTest ‑ should_fail_when_region_or_bucketName_is_missing()
org.eclipse.edc.aws.s3.validator.S3SourceDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid_with_object_name()
org.eclipse.edc.aws.s3.validator.S3SourceDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid_with_object_prefix()
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkFactoryTest ‑ validate_shouldFail_whenValidatorFails()
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkFactoryTest ‑ validate_shouldSucceed_whenValidatorSucceeds()
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [1] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@1a67bde5]
…

♻️ This comment has been updated with latest results.

@ndr-brt ndr-brt force-pushed the 352-extract-validator branch 2 times, most recently from 4a3f447 to 5b8b629 Compare June 21, 2024 10:26
@ndr-brt ndr-brt force-pushed the 352-extract-validator branch from 5b8b629 to 5ebbd15 Compare June 21, 2024 10:29
@ndr-brt ndr-brt merged commit b0f4e8e into main Jun 21, 2024
19 checks passed
@ndr-brt ndr-brt deleted the 352-extract-validator branch June 21, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extract S3DataAddressValidator extension to a separate module
2 participants