Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt to EDC upstream #256

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Briefly describe WHAT your pr changes, which features it adds/modifies.

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

Test Results

60 tests  +10   60 ✅ +10   12s ⏱️ -1s
16 suites + 4    0 💤 ± 0 
16 files   + 4    0 ❌ ± 0 

Results for commit 172697a. ± Comparison against base commit 2a5020a.

This pull request removes 6 and adds 16 tests. Note that renamed tests count towards both.
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [1] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@171f9f2c]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [1] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@5f5efbfc]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [1] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@70abd04e]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [2] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@217ed737]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [2] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@4f3891db]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [2] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@767cacee]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [1] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@1b53e1ae]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [1] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@50bf00c2]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [1] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@6987f367]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [2] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@301db982]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [2] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@7a72fc23]
org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [2] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@9ef7fd8]
org.eclipse.edc.connector.provision.aws.s3.S3BucketProvisionedResourceTest ‑ verifyDeserialize()
org.eclipse.edc.connector.provision.aws.s3.S3BucketProvisionerTest ‑ should_return_failed_future_on_error()
org.eclipse.edc.connector.provision.aws.s3.S3BucketProvisionerTest ‑ verify_basic_provision()
org.eclipse.edc.connector.provision.aws.s3.S3BucketResourceDefinitionTest ‑ toBuilder_verifyEqualResourceDefinition()
…

♻️ This comment has been updated with latest results.

@paullatzelsperger paullatzelsperger force-pushed the fix/update_package_imports branch from dbd9855 to 172697a Compare March 11, 2024 06:56
@paullatzelsperger paullatzelsperger merged commit c9c0904 into main Mar 11, 2024
25 checks passed
@paullatzelsperger paullatzelsperger deleted the fix/update_package_imports branch March 11, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants