Fix option for ignoring type information#2342
Merged
eboasson merged 1 commit intoeclipse-cyclonedds:masterfrom Jan 26, 2026
Merged
Fix option for ignoring type information#2342eboasson merged 1 commit intoeclipse-cyclonedds:masterfrom
eboasson merged 1 commit intoeclipse-cyclonedds:masterfrom
Conversation
The bitmasks for the discovery parameters of interest were cleared incorrectly: the type information is the qos, and the flag to use is not the parameter id but the presence flag. Signed-off-by: Erik Boasson <eb@ilities.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bitmasks for the discovery parameters of interest were cleared incorrectly: the type information is the qos, and the flag to use is not the parameter id but the presence flag.
(I wonder how managed to get #2333 so wrong ... 😑)