-
Notifications
You must be signed in to change notification settings - Fork 350
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ACKNACK event mishandling of AANR_SILENT_NACK (#2049)
* Fix ACKNACK event mishandling of AANR_SILENT_NACK This case is supposed to not send anything at all, only rescheduling the event to send a NACK when we are willing to do that. The early out was missing, causing a (pure) ACK to be generated and a failing assertion in the code updating the state of last ACK sent because it was supposed to be unreachable. In a release build it should not cause more damage than a sometimes sending ACK where sending nothing was intended; in a debug build it would instead crash. Signed-off-by: Erik Boasson <[email protected]> * Consider an event about to be deleted as scheduled The function is used only in one place, for verifying that an ACKNACK event is scheduled if data is known to be missing. It is also be ok if the event is pending deletion because that is tied to the disappearance of the writer. Signed-off-by: Erik Boasson <[email protected]> --------- Signed-off-by: Erik Boasson <[email protected]>
- Loading branch information
Showing
3 changed files
with
50 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters