-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for volumes in K8S/Openshift type components #16505
Conversation
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
crw-ci-test |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few minor nitpicks...
...e/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplierTest.java
Outdated
Show resolved
Hide resolved
...e/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplierTest.java
Outdated
Show resolved
Hide resolved
.../java/org/eclipse/che/api/workspace/server/devfile/validator/DevfileSchemaValidatorTest.java
Show resolved
Hide resolved
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
...e/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just few ideas for var names
[ci-test] |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
E2E tests of Eclipse Che Multiuser on OCP has been successful: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs pr?
What does this PR do?
Support for volumes in K8S/Openshift type components
What issues does this PR fix or reference?
#15122
Release Notes
Docs PR