Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for volumes in K8S/Openshift type components #16505

Merged
merged 4 commits into from
Apr 3, 2020
Merged

Support for volumes in K8S/Openshift type components #16505

merged 4 commits into from
Apr 3, 2020

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented Apr 1, 2020

What does this PR do?

Support for volumes in K8S/Openshift type components

What issues does this PR fix or reference?

#15122

Release Notes

Docs PR

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Apr 1, 2020
@che-bot
Copy link
Contributor

che-bot commented Apr 1, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@mshaposhnik mshaposhnik changed the title Support for volumes in K8S/Openshift tyoe components Support for volumes in K8S/Openshift type components Apr 1, 2020
@che-bot
Copy link
Contributor

che-bot commented Apr 1, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@dmytro-ndp
Copy link
Contributor

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Apr 1, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@mshaposhnik mshaposhnik marked this pull request as ready for review April 2, 2020 06:14
@mshaposhnik mshaposhnik requested review from skabashnyuk and sparkoo and removed request for nickboldt, l0rd, rhopp, sleshchenko and amisevsk April 2, 2020 06:15
Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor nitpicks...

Copy link
Member

@sparkoo sparkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just few ideas for var names

@mshaposhnik
Copy link
Contributor Author

[ci-test]

@che-bot
Copy link
Contributor

che-bot commented Apr 2, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Apr 2, 2020

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Copy link
Contributor

@skabashnyuk skabashnyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs pr?

@mshaposhnik mshaposhnik merged commit 8fca75a into eclipse-che:master Apr 3, 2020
@mshaposhnik mshaposhnik deleted the k8s_volumes branch April 3, 2020 08:03
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants