Fallback to firstTimestamp if lastTimestamp is not set when handling event #16294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skabashnyuk
requested review from
amisevsk,
l0rd,
metlos,
nickboldt,
rhopp and
sleshchenko
as code owners
skabashnyuk
requested review from
sparkoo and
mshaposhnik
and removed request for
nickboldt,
l0rd and
rhopp
che-bot
added
status/code-review
metlos
approved these changes
Mar 10, 2020
sparkoo
approved these changes
Mar 10, 2020
sleshchenko
approved these changes
Mar 10, 2020
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
|
ci-build |
|
[ci-build] |
|
crw-ci-test |
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fallback to firstTimestamp if lastTimestamp is not set when handling event.
Related to kubernetes/kubernetes#86557
What issues does this PR fix or reference?
Fixes #15395
Release Notes
n/a
Docs PR
n/a