Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

chore(happy-path): stick minikube to a working version #1080

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Apr 15, 2021

What does this PR do?

happy path are not working with minikube 1.19.0 which is installed by default on github actions runner
here it changes the default

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19602

How to test this PR?

look if there is a green happy path test with github action (next)

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

Change-Id: I7ab8fb497b77f3d31c231be8d4f2e8491f1b6394
Signed-off-by: Florent Benoit [email protected]

Change-Id: I7ab8fb497b77f3d31c231be8d4f2e8491f1b6394
Signed-off-by: Florent Benoit <[email protected]>
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #1080 (3622203) into master (eeb4526) will increase coverage by 1.80%.
The diff coverage is 49.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
+ Coverage   29.45%   31.26%   +1.80%     
==========================================
  Files         277      277              
  Lines        9336     9391      +55     
  Branches     1380     1403      +23     
==========================================
+ Hits         2750     2936     +186     
+ Misses       6487     6358     -129     
+ Partials       99       97       -2     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <ø> (ø)
...ovisioner/src/node/git-configuration-controller.ts 0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts 0.00% <0.00%> (ø)
...-che-theia-plugin-remote/src/node/plugin-remote.ts 0.00% <0.00%> (ø)
...plugin-remote/src/node/terminal-container-aware.ts 0.00% <0.00%> (ø)
...a-plugin-remote/src/node/webviews-content-aware.ts 0.00% <0.00%> (ø)
...che-theia-remote-api/src/common/devfile-service.ts 0.00% <ø> (ø)
...e-theia-remote-api/src/common/workspace-service.ts 0.00% <ø> (ø)
...er/src/node/che-server-certificate-service-impl.ts 0.00% <0.00%> (ø)
...-impl-k8s/src/node/k8s-certificate-service-impl.ts 0.00% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea5178...3622203. Read the comment docs.

@benoitf
Copy link
Contributor Author

benoitf commented Apr 15, 2021

Happy Path / happy-path (alpine, next) (pull_request) is green

@benoitf benoitf marked this pull request as ready for review April 15, 2021 14:14
@benoitf benoitf requested a review from azatsarynnyy as a code owner April 15, 2021 14:14
@che-bot
Copy link
Contributor

che-bot commented Apr 15, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1080
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1080

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@benoitf benoitf merged commit 6077388 into eclipse-che:master Apr 15, 2021
@benoitf benoitf deleted the minikube branch April 15, 2021 14:19
@che-bot che-bot added this to the 7.30 milestone Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants