Adopt tsp-typescript-client version 0.5.1 and pin inversify to 6.0.3 #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Licences check fails. Ticket has been submitted for the new version: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/17159 |
|
I think the Docker CI failure is most likely unrelated to this PR and probably caused by pulling newer versions of some dependencies. This happens because that example has no lockfile. |
PatrickTasse
previously approved these changes
Nov 11, 2024
bhufmann
changed the title
I added a commit to pin the |
The docker example doesn't have yarn.lock file and hence the builds starts fresh. The new inversify version v6.1.x cause a build error. Signed-off-by: Bernd Hufmann <[email protected]>
Signed-off-by: Bernd Hufmann <[email protected]>
| @@ -14,6 +14,7 @@ | |||
| } | |||
| } | |||
| }, | |||
|
|
|||
There was a problem hiding this comment.
added newline on purpose?
marcdumais-work
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker example doesn't have yarn.lock file and hence the builds starts fresh. The new inversify version v6.1.x cause a build error.
Signed-off-by: Bernd Hufmann [email protected]