Add Bytes. #859
Merged
Add Bytes. #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to merge this tomorrow evening, if no objection. |
Use it for Token and SessionId. Signed-off-by: Achim Kraus <[email protected]>
sbernard31
reviewed
Jan 31, 2019
| * @return bytes as (hexadecimal) string | ||
| */ | ||
| public final String getAsString() { | ||
| return StringUtil.byteArray2HexString(bytes, StringUtil.NO_SEPARATOR, 0); |
There was a problem hiding this comment.
We have many "byte to hex string" function :
- some in
element-connector: StringUtil - others in
scandium: ByteArrayUtils
The scandium version seems to be an optimized one.
Maybe one day we should merge all in element-connector. (and removing duplicate one)
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it for Token and SessionId.
(split from #857)
Signed-off-by: Achim Kraus [email protected]