Added RequestPayloadTest for testing payloads in requests #849
Conversation
| @@ -0,0 +1,336 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2019 Institute for Pervasive Computing, ETH Zurich and others. | |||
| * | |||
There was a problem hiding this comment.
I guess, you don't work for "Institute for Pervasive Computing, ETH Zurich"?
Please replace it either with your name, or, if this is the result of your work for a company, that company name.
There was a problem hiding this comment.
I have changed the header.
|
If you used the Eclipse IDE, californium parent contains a eclipse-formatter-profile.xml. May be you can apply this. If you don't use the Eclipse IDE, I would go to format it after merging your PR. |
|
Yes, the eclipse-formatter-profile is used to format. |
| if (content[i] != (byte) (i % (Byte.MAX_VALUE + 1))) { | ||
| return false; | ||
| } | ||
| ; |
There was a problem hiding this comment.
Please remove the maverick ";"
|
Great! Could you please remove the "maverick" |
|
"maverick" ; is removed and commits squashed to one changeset on the branch |
|
Thanks a lot! Could you please add a "." after the commit message "RequestPayloadTest for testing payloads in requests"? I guess, the ip-validation error is caused by that :-). |
|
I've put a dot after the comment. Doesn't seems to solve it. Is a dot needed after the signed-off line, maybe? |
|
hm, details shows it complains about Signed-off-by footers. But footer looks OK to me... |
Signed-off-by: Rogier Cobben <[email protected]>
|
I committed and pushed again, but using the same e-mail adress as the signing. That seems to solve the problem.. |
|
Yes, it was the "Committer: rogierc [email protected]". |
Added RequestPayloadTest. It containes testcases discussed in issue #834 .
Please review. Especially the CoapNetworkRule and server/client construction.
Signed-off-by: Rogier Cobben [email protected]