Introduce strict payload checks. #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernard31
reviewed
Jan 9, 2019
| /** | ||
| * {@inheritDoc} | ||
| * | ||
| * EMPTY message are never intended to have payload! |
There was a problem hiding this comment.
"messages are" or "message is" ?
| @@ -472,8 +510,15 @@ protected String getPayloadTracingString() { | |||
| * | |||
| * Provides a fluent API to chain setters. | |||
| * | |||
| * @param payload the payload as sting | |||
| * @param payload the payload as sting. {@code null} or a empty string are | |||
| @@ -33,7 +33,7 @@ | |||
|
|
|||
| @Test | |||
| public void testGetHttpEntity() throws Exception { | |||
| Request req = new Request(Code.GET); | |||
| Request req = new Request(Code.PUT); | |||
There was a problem hiding this comment.
I maybe don't get the point here, but should we rename the test name too?
There was a problem hiding this comment.
the next line calls req.setPayload("payload"); so I changed it.
Yes, the test should be then renamed.
| @@ -42,7 +42,7 @@ public void testGetHttpEntity() throws Exception { | |||
|
|
|||
| @Test | |||
| public void testGetHttpEntityWithJSON() throws Exception { | |||
| Request req = new Request(Code.GET); | |||
| Request req = new Request(Code.PUT); | |||
Check, it message is intended to have payload and thorw exceptions, if not. Overwrite that check by mark a message to have unintended payload. Signed-off-by: Achim Kraus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check, it message is intended to have payload and thorw exceptions, if
not. Overwrite that check by mark a message to have unintended payload.
issue #834
Signed-off-by: Achim Kraus [email protected]