Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correlation context and principal to TLS connectors #294

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

boaks
Copy link
Contributor

@boaks boaks commented Apr 24, 2017

Extract correlation context and principal.

Signed-off-by: Achim Kraus [email protected]

@boaks boaks force-pushed the tls_correlation_context branch 4 times, most recently from 0b6c8fb to eaf6692 Compare April 26, 2017 15:20
@boaks boaks force-pushed the tls_correlation_context branch 3 times, most recently from 1636d75 to 5ebbcea Compare June 21, 2017 07:44
@boaks boaks force-pushed the tls_correlation_context branch 2 times, most recently from ef3e394 to a72b229 Compare July 6, 2017 13:58
@boaks boaks force-pushed the tls_correlation_context branch from a72b229 to dc64172 Compare July 27, 2017 13:20
@boaks boaks force-pushed the tls_correlation_context branch from dc64172 to 7853014 Compare October 5, 2017 16:37
@boaks
Copy link
Contributor Author

boaks commented Oct 5, 2017

A little more than the half of the changes are new unit tests.

So @sophokles73, though @sbernard31 is busy with analysing the memory leak (see issue #429), may be you can spent some time on this PR in the next weeks :-),

@sbernard31
Copy link
Contributor

I looked at this really quickly.
All of this is mainly about TCP connector which is (if I well remember) pretty experimental.
Just to say, I'm not against integrated this.

@boaks
Copy link
Contributor Author

boaks commented Oct 10, 2017

Yes, your right. And the spec. seems to be still a draft.

On the other side, it only affects the TCP/TLS stuff ( I see no dependency, which affects function to change for this). So that's for me the difference to BERT, which may affect the UDP blockwise stuff and therefore that's on a separate branch.

@sbernard31
Copy link
Contributor

Any reasons why this is not still not merge ?

@boaks
Copy link
Contributor Author

boaks commented Nov 3, 2017

I didn't want to influence other PRs.
Currently I work on moving the rpk trust stores.
And when I'm finished with that, then I would go to rebase and retest this and have it merged.

@boaks boaks force-pushed the tls_correlation_context branch from a85d361 to 679fdd5 Compare November 3, 2017 13:44
@boaks boaks force-pushed the tls_correlation_context branch from 679fdd5 to edbf1e2 Compare November 3, 2017 13:54
@boaks boaks merged commit cddb60d into eclipse-californium:2.0.x Nov 3, 2017
@boaks boaks deleted the tls_correlation_context branch February 20, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants