Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-exist source folder when it's optional #1197

Merged
merged 5 commits into from
Aug 24, 2022

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Aug 11, 2022

Signed-off-by: sheche [email protected]

Fixes #1196

Context

Copy link
Contributor

@donat donat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I only have a couple of comments on the test coverage.

@donat donat merged commit 2d784cb into eclipse-buildship:master Aug 24, 2022
@donat
Copy link
Contributor

donat commented Aug 24, 2022

@jdneo Thank you for the contribution!

@jdneo jdneo deleted the cs/issue-1196 branch August 25, 2022 01:36
@jdneo
Copy link
Contributor Author

jdneo commented Aug 25, 2022

@donat Thank you too for reviewing and providing help 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow optional source directory to be added into project classpath
2 participants