Skip to content
This repository has been archived by the owner on Feb 6, 2025. It is now read-only.

nsp check reports security vulnerabilities related to mosca 1.1.3 #34

Closed
faif opened this issue Dec 29, 2016 · 3 comments
Closed

nsp check reports security vulnerabilities related to mosca 1.1.3 #34

faif opened this issue Dec 29, 2016 · 3 comments

Comments

@faif
Copy link

faif commented Dec 29, 2016

ponte version: 0.0.16

nsp check reports the following 3 vulnerabilities:

Regular Expression Denial of Service
[email protected] > [email protected]
https://nodesecurity.io/advisories/55

DoS due to excessively large websocket message
[email protected] > [email protected] > [email protected]
https://nodesecurity.io/advisories/120

Remote Memory Disclosure
[email protected] > [email protected] > [email protected]
https://nodesecurity.io/advisories/67

@chombium
Copy link
Contributor

Hi @faif,

thanks for taking time to check the security of Ponte and reporting these issues.

We are currently working on updating the dependencies and refactoring Ponte to work with the latest version of node #28, #29, #30. The latest version of Mosca is 2.2.0, so maybe these issues have been already solved. After this is finished we will run the tests again...
There is a suggestion that we replace Mosca with Aedes #32

Maybe we can add "nsp check" to the pre-commit hooks as well...

Best Regards,
Jovan

@chombium
Copy link
Contributor

chombium commented May 5, 2017

Hi @faif,

with the last merge in the master branch #41 this issue should be solved.
Can you please checkout the code from the master branch, retest and if everything is good close this issue.

Best Regards,
Jovan

@faif
Copy link
Author

faif commented May 12, 2017

@chombium Looks good now, nice 👍

@faif faif closed this as completed May 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants