Skip to content
This repository has been archived by the owner on Feb 6, 2025. It is now read-only.

Add better check style and code formatting #29

Closed
chombium opened this issue Dec 21, 2016 · 4 comments
Closed

Add better check style and code formatting #29

chombium opened this issue Dec 21, 2016 · 4 comments

Comments

@chombium
Copy link
Contributor

Add better check style and code formatting based on ESLint and refactor the souce code to reflect the changes

@chombium
Copy link
Contributor Author

chombium commented Dec 21, 2016

Browsing the source code of aedes mentioned by @mcollina in #32 I noticed that he used StandardJS for the project.
StandardJS looks really nice and since it works out of the box and there are no configuration files to maintain and adjust. I think it would be better option

@mcollina
Copy link
Contributor

That's my idea :)

@chombium
Copy link
Contributor Author

chombium commented Jan 9, 2017

I added StandardJS and reformatted the code to conform it's rules. I didn't add StandardJS as a development dependency because code formatting and check style is something that is a must for every project. So I prefer using globally installed standardJS instead of duplication in each project.

I will create one big pull request together with the changes for #28 and #30 when I'm finished.

@chombium
Copy link
Contributor Author

chombium commented May 7, 2017

The changes have been merged into the master

@chombium chombium closed this as completed May 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants