feat(actions) Add additional encrypt/decrypt actions. Allow session create to use different users. #23
Conversation
This PR is tackling two very important issues. 1) A complex config for the consuming app's Fastlane setup 2) A way to authorize a session and then later login with different accounts.
|
Can we please update the readme to include which |
lib/fastlane/plugin/react_native_release/actions/add_app_var.rb
Outdated
Show resolved
Hide resolved
lib/fastlane/plugin/react_native_release/actions/decrypt_app_vars.rb
Outdated
Show resolved
Hide resolved
| tag_prefix = 'releases' | ||
| base_branch = params[:beta_branch] | ||
| target_branch = params[:production_branch] | ||
| # TODO: ohter branches |
| sh "git show-ref #{target_branch}" do |status| | ||
| sh "git branch -D #{target_branch}" if status.success? | ||
| end | ||
| # if !is_hotfix |
|
|
||
| def self.authors | ||
| # So no one will ever forget your contribution to fastlane :) You are awesome btw! | ||
| ["cball", "isaiahgrey93"] |
There was a problem hiding this comment.
look forward to increasing this array size 😄
| is_beta = target.include?('beta') | ||
| is_hotfix = params[:hotfix] === true | ||
| release_type = params[:release_type] || UI.select("Select a release type:", VALID_RELEASE_TYPES) | ||
| is_beta = release_type.include?('beta') |
There was a problem hiding this comment.
Not important at all, but these three lines (and the following conditional) could be done metaprogram-y to set the state for more release types in the future.
There was a problem hiding this comment.
totally agree. I want to rework this whole action in a followup PR to properly support master-based and gitflow-based workflows (and hotfixes). I'll try and clean up there as well.
This PR is tackling two very important issues.
Changes
create_fastlane_session. It now re-uses some ENV vars, and prompts for the user to release as.add_app_varaction to add a single env vardecrypt_android_keystoreandgenerate_android_keystoreto make working with keystores easierencrypt_app_varsanddecrypt_app_varsto handle writing / restoring ENV.decrypt_app_varstakes an optional namespace which allows us to override foralpha,beta, orreleaseencrypt_google_play_credentialsanddecrypt_google_play_credentialsto handle writing/restoring the Google Play JSON