Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #324

Merged
merged 2 commits into from
Aug 19, 2023
Merged

chore: upgrade dependencies #324

merged 2 commits into from
Aug 19, 2023

Conversation

kgajera
Copy link
Contributor

@kgajera kgajera commented Aug 18, 2023

Changes

Upgrades all dependencies. Manually tested the sign up and login to verify it still works.

Checklist

  • Requires dependency update?
  • Generating a new app works

@@ -23,7 +23,7 @@ export const userRouter = t.router({
.input(z.object({ id: z.string().optional(), email: z.string().optional() }).optional())
.query(({ ctx, input }) => ctx.db.user.findMany({ where: input, select: defaultUserSelect })),
find: t.procedure
.input(z.object({ id: z.string().optional(), email: z.string().optional() }))
.input(z.union([z.object({ id: z.string() }), z.object({ email: z.string() })]))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change requires either the id or email to be given.

Fixes this error after upgrading Prisma:
Screen Shot 2023-08-18 at 4 17 10 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of z.union

Copy link
Contributor

@cullylarson cullylarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -23,7 +23,7 @@ export const userRouter = t.router({
.input(z.object({ id: z.string().optional(), email: z.string().optional() }).optional())
.query(({ ctx, input }) => ctx.db.user.findMany({ where: input, select: defaultUserSelect })),
find: t.procedure
.input(z.object({ id: z.string().optional(), email: z.string().optional() }))
.input(z.union([z.object({ id: z.string() }), z.object({ email: z.string() })]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of z.union

@kgajera kgajera merged commit 6e1f273 into canary Aug 19, 2023
6 checks passed
@kgajera kgajera deleted the chore/upgrade-dependencies branch August 19, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants