Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #259

Merged
merged 7 commits into from
May 6, 2022
Merged

chore: upgrade dependencies #259

merged 7 commits into from
May 6, 2022

Conversation

kgajera
Copy link
Contributor

@kgajera kgajera commented May 5, 2022

Changes

Fixes #237

@kgajera kgajera marked this pull request as draft May 5, 2022 14:37
@@ -10,13 +10,13 @@ on:
jobs:
release:
name: Release
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning latest can create unintended behavior when a new "latest" is released. Not necessarily a deal-breaker for using it, but something to consider.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed this was a draft 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! Appreciate the comment. Pinned it down to 20.04. PR is now ready for review.

@kgajera kgajera force-pushed the ci/update-node-matrix branch from be7be56 to c280c23 Compare May 6, 2022 00:27
Copy link
Contributor

@cullylarson cullylarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this runs in Github Actions, it looks good to me!

@kgajera kgajera marked this pull request as ready for review May 6, 2022 16:32
@kgajera kgajera merged commit 57b3a8e into canary May 6, 2022
@kgajera kgajera deleted the ci/update-node-matrix branch May 6, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress 8.6 failing in CI
2 participants