-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade dependencies #259
Conversation
.github/workflows/release.yml
Outdated
@@ -10,13 +10,13 @@ on: | |||
jobs: | |||
release: | |||
name: Release | |||
runs-on: ubuntu-18.04 | |||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning latest can create unintended behavior when a new "latest" is released. Not necessarily a deal-breaker for using it, but something to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just noticed this was a draft 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem! Appreciate the comment. Pinned it down to 20.04. PR is now ready for review.
be7be56
to
c280c23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this runs in Github Actions, it looks good to me!
Changes
Fixes #237