Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to run any bison dev app script #234

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

kgajera
Copy link
Contributor

@kgajera kgajera commented Oct 8, 2021

Changes

This is an improvement to the development workflow for the template. Before this change, you could only run yarn dev (from packages/create-bison-app) to run the template's dev script. This is still the default functionality.

Now in addition to that, yarn dev supports a new optional argument: yarn dev [script]

So from the packages/create-bison-app directory, you can run yarn dev [script] where [script] is the name of any script in packages/create-bison-app/dist/bison-dev-app/package.json. For example, you can run yarn dev test to run the "test" script in the bison app.

How to test

In the packages/create-bison-app directory, you can run yarn dev test, yarn dev build:types, or any script from the template's package.json.

Checklist

  • Requires dependency update?
  • Generating a new app works

@kgajera kgajera force-pushed the feat/run-bison-dev-app-scripts branch from 4f7b8f4 to bc26543 Compare October 8, 2021 20:25
@kgajera kgajera force-pushed the feat/run-bison-dev-app-scripts branch from bc26543 to 990a7a2 Compare October 18, 2021 20:59
@kgajera kgajera force-pushed the feat/run-bison-dev-app-scripts branch from 990a7a2 to 20aff2a Compare November 4, 2021 22:47
Copy link
Member

@cball cball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kgajera kgajera merged commit 4860b9f into canary Nov 5, 2021
@kgajera kgajera deleted the feat/run-bison-dev-app-scripts branch November 5, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants