Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember 2.18.2 #473

Merged
merged 1 commit into from
Apr 16, 2018
Merged

ember 2.18.2 #473

merged 1 commit into from
Apr 16, 2018

Conversation

GavinJoyce
Copy link
Collaborator

@GavinJoyce GavinJoyce commented Feb 22, 2018

Part of #462

This PR upgrades ember-model to use Ember 2.18.2. In order to minimise changes, I've tried to replicate the previous container logic with getOwner and setOwner.

TODO:

@GavinJoyce
Copy link
Collaborator Author

I cut a custom build based on our Intercom fork and it seems to work well in dev:

screen shot 2018-02-22 at 11 23 34

@GavinJoyce GavinJoyce mentioned this pull request Feb 27, 2018
@GavinJoyce GavinJoyce merged commit f6ff799 into master Apr 16, 2018
@GavinJoyce GavinJoyce deleted the gj/ember-2.18.2 branch April 16, 2018 07:59
@GavinJoyce GavinJoyce mentioned this pull request Apr 16, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant