Reverts frame_by_id behaviour #872
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to https://github.com/ebroecker/canmatrix/pull/825.
While speeding up
frame_by_id
is useful, it changes the original behavior: Our environment expects a fresh, up-to-date frame each call, whereas the cache may return outdated data (e.g. after renaming a frame).To stay consistent with other APIs, I’d suggest keeping two variants:
get_frame_by_attribute
: cache-basedframe_by_attribute
: always searchesAlternatively, the cache could be reset whenever a frame attribute changes, but that would require much more intrusive changes. I’d prefer keeping the PR as minimally invasive as possible.