Simplifying modular usage of finance.js, dispensing the main "class" #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all other functions
|
Hi @igorsantos07, |
igorsantos07
added a commit
to igorsantos07/finance.js
that referenced
this pull request
Apr 7, 2017
…ng Finance both as an instance object and namespace-class
igorsantos07
added a commit
to igorsantos07/finance.js
that referenced
this pull request
Apr 7, 2017
…g Finance both as an instance object and namespace-class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #22, although it would probably break current usage of
var Finance = new Finance();EDIT: I've added a couple of other functions and changes. If you want I can create separate branches for those so you can merge accordingly - but please, read the commited changes first to see if they fit the project.