Skip to content

Commit

Permalink
#130 make sure config is explicitely defined as arg. Special arg ... …
Browse files Browse the repository at this point in the history
…should be limited to WFS vendor params
  • Loading branch information
eblondel committed Jan 27, 2025
1 parent 54b7c37 commit 57e231a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
7 changes: 5 additions & 2 deletions R/WFSFeatureType.R
Original file line number Diff line number Diff line change
Expand Up @@ -283,12 +283,15 @@ WFSFeatureType <- R6Class("WFSFeatureType",
#'@param parallel whether to get features using parallel multicore strategy. Default is \code{FALSE}
#'@param parallel_handler Handler function to parallelize the code. eg \link{mclapply}
#'@param cl optional cluster object for parallel cluster approaches using eg. \code{parallel::makeCluster}
#'@param config an additional config from \pkg{httr} package
#'@return features as object of class \code{sf}
getFeatures = function(...,
validate = TRUE,
outputFormat = NULL,
paging = FALSE, paging_length = 1000,
parallel = FALSE, parallel_handler = NULL, cl = NULL){
parallel = FALSE, parallel_handler = NULL, cl = NULL,
config = httr::config()
){

#getdescription
if(is.null(self$description)){
Expand Down Expand Up @@ -350,7 +353,7 @@ WFSFeatureType <- R6Class("WFSFeatureType",
WFSGetFeature$new,
c(
capabilities = private$capabilities, op = op, url = private$url, version = private$version, typeName = private$name, outputFormat = outputFormat,
user = client$getUser(), pwd = client$getPwd(), token = client$getToken(), headers = client$getHeaders(),
user = client$getUser(), pwd = client$getPwd(), token = client$getToken(), headers = client$getHeaders(), config = config,
logger = self$loggerType,
vendorParams
)
Expand Down
5 changes: 4 additions & 1 deletion man/WFSFeatureType.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 57e231a

Please sign in to comment.