Develop #872
Merged
Develop #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ravenfield support
# Conflicts: # src/model/game/GameManager.ts
Aloft support
Added COTL support
Added support for 64 bit Chrono Ark
Fix bepinex be linux
Added BONELAB support
Fix return type annotation and simplify method implementations.
DRY up the code that's called before app restart to prevent the previously selected default game from being reselected automatically. Extract the code to ManagerSettings to decouple it from the Vue components. Refs TS-1137
In the past, a restart was required when a different game was selected due to implementation details, but those conditions haven't applied for some time now. Instead of restarting the app, simply redirect the user back to game selection view. Refs TS-1137
…out-restart Change selected game without restarting the app
Attempt to improve code quality, although most of the changes are subjective. Move the migration check into Vuex store so it doesn't get called multiple times now that the game selection screen can be accessed without restarting the app. The cache cleaning was removed, since it failed if the old directory structure was still used: it tried to read the profiles from a non- existing dir. Refs TS-1138
Remove unnecessary layout spacing in order to enable more compact layout to render nicely e.g. on smaller resolutions.
Remove unnecessary layout spacing
Trombone champ support
Extract any logic out of the component, only setting the attributes by calling helper methods. Clean up unnecessary code and attempt to simplify the implementation. Refs TS-1138
…een-refactor Refactor GameSelectionScreen.created()
Also turn the if-check around to save an indentation level. Refs TS-1139
Vue component doesn't need to know what activating a game consists of. Refs TS-1139
Vue component doesn't need to know what providers need to be setup and how it's done when the active game is selected. Refs TS-1139
The switch statement in the Vue component seemed unnecessary: all three valid options did the exact same thing. Refs TS-1139
Due to z-index, the modal was shown partially below the search bar in GameSelectionScreen.
Build process doesn't currently support nullish coalescing.
Replace nullish coalescing operator with OR operator
…-refactor Refactor GameSelectionScreen's "proceed" methods
PC Game Pass support
Add game support: Rogue : Genesia
Up to now, the game selection screen has assumed game thumbnails to be a specific resolution, and would render them as is. This commit declares CSS that will scale the thumbnails appropriately regardless of what the source image size is in reality.
Also introduce a better way to re-use BepInEx game definitions as well as improve the type checking regarding game names.
Re-use the base bepinex install rules for most games and remove the copypasted duplicate code it replaces.
Add game support: Across the Obelisk
The workflow attemps to build Electron apps based on the Quasar config. Apps are built on Windows, Linux and Mac platforms. Hopefully this will catch changes that break things before they're merged to master/develop branches. Refs TS-1218
Remove duplicate code from install rules
Add GitHub Actions workflow for building the app
Updated README and versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.