Always track changes to mods.yml when installing mods to a profile #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both regular installation and importing a profile now use the same helper function. Effectively this means that import now tracks installed mods to profile's mods.yml file instead of copying the file as-is from the exported zip. This restores compatibility with profiles exported with Gale, and closes one potential attack vector. Profile exporting no longer includes the mods.yml in the zip files. Profile import ignores the file even if it exists to accommodate older profiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both regular installation and importing a profile now use the same helper function. Effectively this means that import now tracks installed mods to profile's mods.yml file instead of copying the file as-is from the exported zip. This restores compatibility with profiles exported with Gale, and closes one potential attack vector.
Profile exporting no longer includes the mods.yml in the zip files. Profile import ignores the file even if it exists to accommodate older profiles.