Show progress of each step in the profile import modal #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially progress was based purely on downloading the mods. It was recently changed so that extracting the downloaded mod to cache is allocated 20% of the progress of processing the mod in this step. However, this still leaves users hanging on 100% completion while the mods from the cache and configs from the imported profile zip are copied to the profile folder. These steps now have their own progress indicators.
VilppeRiskidev
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially progress was based purely on downloading the mods. It was recently changed so that extracting the downloaded mod to cache is allocated 20% of the progress of processing the mod in this step.
However, this still leaves users hanging on 100% completion while the mods from the cache and configs from the imported profile zip are copied to the profile folder. These steps now have their own progress indicators.