Refactor ProfileInstallerProvider to use ImmutableProfile when enabling/disabling mods #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is not used anywhere, at least anymore.
The method isn't called from the outside and looks more like an implementation detail for enableMod/disableMod methods.
applyModModeForSubdir creates FileTree objects internally and applyModModeForState doesn't use FileTrees at all.
The location is always derived from the Profile object, which is passed as an argument anyway. Furthermore, applyModModeForSubdir doesn't even use the argument.
Ideally only ImmutableProfiles would be used, but settle for supporting both Profiles and ImmutableProfiles for now to limit the scope of this refactoring effort.
Now that the methods called by the actions which enable/disable mods accept ImmutableProfiles as arguments, it makes sense for the actions themselves to also use ImmutableProfiles.
VilppeRiskidev
approved these changes
Oct 9, 2024
Base automatically changed from
immutable-profile-pt4-downloadprovider
to
develop
October 14, 2024 11:58
anttimaki
deleted the
immutable-profile-pt5-profileinstallprovider-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.