Fix mod disable toggle #1290
Merged
Fix mod disable toggle #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mod disabled status was toggled multiple times while the first change was processed, the files ended up with multiple suffixes. When the mod was then toggled to enabled the files still had the suffix and the mod would now be loaded. The caveat is that any files that actually using .old as file extension will get it ripped off if the mod is disabled and enabled again. While not ideal, I see this as the lesser evil.
- Prevent mod enable/disable toggle starting another process while one is already in progress - Don't disable the input element itself, since this would show a disabled checkbox while the process is in progress, and I don't want to deal with the CSS right now - Make switch ids unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.