Replace mod exclusions URL with a constant #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebkr
reviewed
Feb 9, 2024
src/r2mm/manager/ModLinker.ts
Outdated
| } | ||
| } else { | ||
| if ((await fs.lstat(path.join(profile.getPathOfProfile(), file))).isDirectory()) { | ||
| if (!["bepinex", "bepinex_server", "mods", "melonloader", "plugins", "userdata", "_state", "userlibs", "qmods"].includes(file.toLowerCase())) { | ||
| const exclusionsList = [ |
There was a problem hiding this comment.
You could declare this at the top of the file outside of the class if that's easier. It wouldn't need to be recreated every time this is hit.
There was a problem hiding this comment.
This was a part of #1079 but yeah agreed, didn't end up making it a blocker however.
Replace the mod exclusions list URL with a constant as the same value is used for all the games. This could perhaps be moved to the game definition directly, but that would need a larger change than this commit is intended as.
ebkr
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the mod exclusions list URL with a constant as the same value is used for all the games.
This could perhaps be moved to the game definition directly, but that would need a larger change than this commit is intended as.
Merge #1079 first!