Develop (v3.1.46) #1166
Merged
Develop (v3.1.46) #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a bit of information on how to get the development environment run refs -
Add DevEnvSetup.md
The implementation is "backported" from Thunderstore Mod Manager since it's now needed in r2mm too. Refs TS-2003
Refs TS-2003
A class containing static methods intended to provide support for multiple Thunderstore CDNs: - Check connection to CDNs and remember which one works - Provide a method for replacing the CDN host from URLs. This can be used when the mod manager uses the URL directly. - Provide a method for augmenting an URL with a query parameter denoting the preferred CDN. This can be used when download happens via a redirect from Thunderstore API, although it requires that the API endpoint has been set up to deal with the query parameter. Refs TS-2003
This is required so that also the UtilityMixin can show the error modal in the future. Refs TS-2003
A list of predefined CDNs are tested, and the first one that is reached will be stored internally by CdnProvider as the preferred one. Other parts of the code that deal with CDNs can use the static helper methods provided by the class. If no CDN can be reached, an error modal is shown to the user about the issue. Hopefully the provided suggestion will help some users. Refs TS-2003
Since the icon URLs for non-installed packages are read from the PackageVersion metadata and downloaded by the browser, brute force replacement of the domain is required. Refs TS-2003
Since the actual download URL is returned by the Thunderstore API as a redirect, signal the API with a query parameter that an alternative CDN is preferred. Refs TS-2003
Since the actual download URL is returned by the Thunderstore API as a redirect, signal the API with a query parameter that an alternative CDN is preferred. Refs TS-2003
Support alternative Thunderstore CDN
Add Meeple Station Add Void Crew
Newer communities have a different URL structure for showing a specific version of a package than the older communities that use subdomains. Installed mods tried to link to a specific version, but the links were broken for the new communities, which confused users. Always link to the non version specific page as a quick fix. A proper fix would require backend changes and/or an actual spec. One could sniff the base URL to determine how to link to a specific version, but this would be prone to break if the URL structure change again (e.g. once the new Thunderstore website is launched). Since the button doesn't lead to the actual installed version anymore, use "website" as the label instead of the version number. This is in line with how the non-installed mods currently link to the website. Since the version number needs to be shown somewhere, show it on the package title row instead.
Remove version number from links leading to Thunderstore website
Change the online mod list pagination to only render page buttons for pages in the near vicinity of the current page as well as the first and last page. This significantly improves the experience for games with a lot of mods available.
Center align the text content of the online mod list pagination buttons.
Now that the pagination behaves well even with a large amount of pages, we can cut down on the page size to a more performant amount. This should reduce latency between page swaps.
Create a vue component for handling pagination button rendering and take it into use on the OnlineModview template
Improve pagination support for large page counts
Updated CHANGELOG and versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.