-
Notifications
You must be signed in to change notification settings - Fork 199
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve "enter profile code" phase of profile import modal
- Remove the somewhat unnecessary "You haven't entered a code" and "You may import the profile" badges that mostly just look awkward - Show "Invalid code" badge only if a profile code has been entered - Remove the big red button when a valid profile code hasn't been entered. This looked like an error state before user has entered the code. Just disabling the Continue button if the code is invalid seems sufficient - Combine the two remaining buttons into one - Prevent submitting the form when the download is already in progress, both via button and key press - Move isProfileCodeValid helper to modal components as that's the only place where it's used. Remove the unnecessary argument to make the method a computed value
- Loading branch information
Showing
2 changed files
with
13 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters