Save R15 before global access #255
Merged
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable In -buildmode=plugin R15 is used when accessing global variables but we need to save it since we are actually called from C code. We save the R15 register before we access any globals.
hajimehoshi
reviewed
Jun 18, 2024
hajimehoshi
reviewed
Jun 18, 2024
.github/workflows/test.yml
Outdated
| @@ -39,6 +39,12 @@ jobs: | |||
| run: | | |||
| go vet -v ./... | |||
|
|
|||
| - name: go build plugin | |||
| if: runner.os == 'Linux' | |||
There was a problem hiding this comment.
plugin should work not only on Linux but also macOS and FreeBSD. Is there a reason why we specify Linux here?
There was a problem hiding this comment.
I didn’t think it was necessary since they all behave the same but I can to be safe
There was a problem hiding this comment.
Let's do this if it is easy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #254