[pull] main from withastro:main #133
Open
+207,158
−46,436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* refactor: use `vitest` for benchmarks * increase timeout * increase timeout * Restore correct label
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* ci: update repro link * Apply suggestions from code review
* fix: this message adds no value to developers; it checks against a static list of renderers while Astro allows to dynamically add custom renderers * feat: added framework-custom example to demonstrate the use of custom renderers with the log message fixed * chore: changeset added and package lock updated * chore: fix lint issue, but keeping arguments commented out for reference (real-world use) * chore: removed the example and updated the changeset accordingly * test: added fixture and test to prove the new behaviour * test: removing this specific test since it's only guarding if we ever revert this PR * Update test --------- Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: bluwy <[email protected]>
* Remove fileurl handling * fix
* fix: experimental svg types * apply suggestion
* fix custom assetFileNames issue * fix error * fix asset name * handle edge cases fo multiple asset dirs * add tests * format * add changeset * improve changeset * add missing files for tests * Update neat-papayas-brake.md improve changeset
* fix: don't apply duplicate class to images * Fromat
* fix(i18n): pass search params to fallback * test(i18n): add test for search param fix * test(i18n): resolve mantainer comments
* chore: better warning * Apply suggestions from code review Co-authored-by: Sarah Rainsberger <[email protected]> --------- Co-authored-by: Sarah Rainsberger <[email protected]>
* Upstream Zod error map improvements from Starlight * Update tests * Use Zod error map when validating user config * Update user config error formatting for error map * Tweak colours * Separate colour and indentation steps for clarity * Fix broken link to experimental flag documentation * Add changeset * Update tests * Fix one more test * Use existing utility for bold and other Markdown formatting * Extract codeRegex to top level * Don’t dim text and tweak indentation
* fix: correctly copy to clipboard on mac * Add platform-specific clipboard handling for Linux * Wording * Update .changeset/angry-pumas-act.md Co-authored-by: Emanuele Stoppa <[email protected]> * Use console.info --------- Co-authored-by: Emanuele Stoppa <[email protected]>
…12644) * fix(@astrojs/rss): use standard rss content type, add utf-8 charset * Update .changeset/loud-cobras-rhyme.md --------- Co-authored-by: Matt Kane <[email protected]>
* Keep clientAddress on cloned requests User observed that calling actions resulted in an error about not having clientRequest available. This is because the user had a middleware that cloned the request, which loses all of the symbols. The fix is to pass the clientAddress directly into the RenderContext. This deprecates the `clientAddressSymbol`, but we need to keep it for now because some adapters set the clientAddress that way. Note that similar fixes should be done for other symbol usage on the Request object (locals is one). * changeset * fix build stuff * Update packages/astro/src/core/render-context.ts * Update changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: allow imports of Markdown files as raw text * Switch to hasSpecialQueries * Update test * Update changeset
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
* Improve error handling for content collection entries where ID isn't a string * Add passthrough to zod schema to still access other properties after validation * Add new test for numbers as IDs, add changeset * Update error for invalid IDs * Update test for new error message * Update .changeset/dry-dragons-shout.md Co-authored-by: Sarah Rainsberger <[email protected]> * Update errors-data.ts to (possibly) fix tests failing * Update errors-data.ts --------- Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Matt Kane <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: Matt Kane <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]>
* chore: adds wontfix label action * Wording * Update .github/workflows/issue-labeled.yml Co-authored-by: Sarah Rainsberger <[email protected]> --------- Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: HiDeoo <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: Matt Kane <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: ascorbic <[email protected]> Co-authored-by: sarah11918 <[email protected]> Co-authored-by: yanthomasdev <[email protected]>
Co-authored-by: florian-lefebvre <[email protected]> Co-authored-by: sarah11918 <[email protected]> Co-authored-by: yanthomasdev <[email protected]>
Co-authored-by: ematipico <[email protected]> Co-authored-by: matthewp <[email protected]> Co-authored-by: sarah11918 <[email protected]> Co-authored-by: bluwy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )